ADRs tagged "php"
6 deciders
drupal, composer, php
Decided on
Allowing builds to succeed with failed patches can lead to malformed code or hidden errors.
Use local copies of patch files
accepted
7 deciders
drupal, php, composer
Decided on
When using cweagans/composer-patches, it is important that patch sources are consistent and do not change between builds.
7 deciders
drupal, php, composer
Decided on
Validating a complete Composer configuration is important to ensuring build issues are caught early.
6 deciders
drupal, php, composer
Decided on
Drupal's git repository has a different directory structure than projects built on Drupal. Default Composer Patches settings can cause Drupal patches to be silently misapplied.
6 deciders
drupal, php, composer
Decided on
Default
composer-patchessettings can lead to misapplied patches or hidden errors. Using a consistent configuration across projects will reduce errors and save time.5 deciders
drupal, php, coding, testing
Decided on
2 deciders
drupal, php, coding
Decided on
Following stricter typing where available can significantly reduce bugs, and simplify maintainability. This has been proven by several studies across different disciplines.
Use strict types in PHP code
accepted
4 deciders
php, drupal
Decided on
PHP's type coercion can cause logical errors within a program. For example, when a float is cast to an int, the decimal portion is lost. We aim to reduce these errors in our code, but they can easily slip through manual code review. Following stricter typing where available can significantly reduce bugs, as shown by Python's urllib3 type hinting case study.